Skip to content

Update assemblyinstaller.cs #4044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from Mar 30, 2020
Merged

Update assemblyinstaller.cs #4044

merged 3 commits into from Mar 30, 2020
+2 −9

Conversation

ghost
Copy link

@ghost ghost commented Mar 27, 2020

Summary

I removed the catch-block which catches ArgumentException.

@ghost ghost self-requested a review as a code owner March 27, 2020 08:59
@dotnet-bot dotnet-bot added this to the March 2020 milestone Mar 27, 2020
BillWagner
BillWagner approved these changes Mar 27, 2020
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this simplification @Asugakoisi

I'll :shipit: now.

@mairaw
Copy link
Contributor

mairaw commented Mar 30, 2020 •
edited
Loading

@BillWagner make sure the changes are made to the other languages too. VB does have the same example: https://github.com/dotnet/dotnet-api-docs/blob/master/samples/snippets/visualbasic/VS_Snippets_CLR/AssemblyInstaller/VB/assemblyinstaller.vb (didn't check others)

Asugakoisi added 2 commits March 31, 2020 03:37
@ghost
Copy link
Author

ghost commented Mar 30, 2020

I removed the catch-block which catches ArgumentException of C++ and VB source.

@BillWagner BillWagner merged commit 73381c2 into dotnet:master Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
March 2020
Development

Successfully merging this pull request may close these issues.
3 participants
@mairaw @BillWagner @dotnet-bot